Re: ip_conntrack locks up hard on 2.4.0 after about 10 hours

From: David S. Miller (davem@redhat.com)
Date: Sat Jan 06 2001 - 18:29:39 EST


   Date: Sat, 06 Jan 2001 10:37:54 -0500
   From: safemode <safemode@voicenet.com>

   Jan 6 06:18:10 icebox kernel: reset_xmit_timer sk=c17fd040 1
   when=0x5d9e, caller=c01a6bf1

I posted a fix for this on Linux-kernel yesterday, had you tested it
you would have seen at least this part of your problem report go away.
I'm reposting the fix for your convenience:

--- net/ipv4/tcp_input.c.~1~ Wed Dec 13 10:31:48 2000
+++ net/ipv4/tcp_input.c Fri Jan 5 17:01:53 2001
@@ -1705,7 +1705,7 @@
 
                 if ((__s32)when < (__s32)tp->rttvar)
                         when = tp->rttvar;
- tcp_reset_xmit_timer(sk, TCP_TIME_RETRANS, when);
+ tcp_reset_xmit_timer(sk, TCP_TIME_RETRANS, min(when, TCP_RTO_MAX));
         }
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jan 07 2001 - 21:00:26 EST