Re: PROBLEM: 2.4.0 Kernel Fails to compile when CONFIG_IP_NF_FTP is selected

From: Rusty Russell (rusty@linuxcare.com.au)
Date: Fri Jan 05 2001 - 21:40:35 EST

In message <200101060059.QAA09816@pizda.ninka.net> you write:
>
> You need to enable both CONNTRACK and full NAT in your configuration.
>
> Rusty, why doesn't the Config stuff just enforece this if it
> is necessary when enabling FTP support etc.?

Deja Vu: we've been through this before. But someone else
fuck^H^H^H^Hfixed the makefiles recently.

CONFIG_IP_NF_FTP controls BOTH the ftp connection tracking and NAT
code. The correct fix is below (untested, but you get the idea).

Matthew, does this fix it for you?
Rusty. 

--
Hacking time.

diff -urN -I \$.*\$ -X /tmp/kerndiff.SnTZ7N --minimal linux-2.4.0-official/net/ipv4/netfilter/Config.in working-2.4.0/net/ipv4/netfilter/Config.in
--- linux-2.4.0-official/net/ipv4/netfilter/Config.in	Tue Mar 28 04:35:56 2000
+++ working-2.4.0/net/ipv4/netfilter/Config.in	Sat Jan  6 13:36:34 2001
@@ -42,6 +42,10 @@
       define_bool CONFIG_IP_NF_NAT_NEEDED y
       dep_tristate '    MASQUERADE target support' CONFIG_IP_NF_TARGET_MASQUERADE $CONFIG_IP_NF_NAT
       dep_tristate '    REDIRECT target support' CONFIG_IP_NF_TARGET_REDIRECT $CONFIG_IP_NF_NAT
+      # If they want FTP, set same as $CONFIG_IP_NF_NAT (m or y).
+      if [ "$CONFIG_IP_NF_FTP" != "n" ]; then
+	define_tristate CONFIG_IP_NF_NAT_FTP $CONFIG_IP_NF_NAT
+      fi
     fi
   fi
 
diff -urN -I \$.*\$ -X /tmp/kerndiff.SnTZ7N --minimal linux-2.4.0-official/net/ipv4/netfilter/Makefile working-2.4.0/net/ipv4/netfilter/Makefile
--- linux-2.4.0-official/net/ipv4/netfilter/Makefile	Sat Dec 30 09:07:24 2000
+++ working-2.4.0/net/ipv4/netfilter/Makefile	Sat Jan  6 13:36:25 2001
@@ -35,7 +35,7 @@
 obj-$(CONFIG_IP_NF_FTP) += ip_conntrack_ftp.o
 
 # NAT helpers 
-obj-$(CONFIG_IP_NF_FTP) += ip_nat_ftp.o
+obj-$(CONFIG_IP_NF_NAT_FTP) += ip_nat_ftp.o
 
 # generic IP tables 
 obj-$(CONFIG_IP_NF_IPTABLES) += ip_tables.o
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun Jan 07 2001 - 21:00:24 EST