[patch] 2.4.0: lp superuser check

• Next message: Marek Gresko: "2.4.0 TCP SYN problem"
• Previous message: Horst von Brand: "2.4.0-ac1 on sparc64: Build problems"
• Next in thread: David Weinehall: "suser() check audit Was: [patch] 2.4.0: lp superuser check"
• Reply: David Weinehall: "suser() check audit Was: [patch] 2.4.0: lp superuser check"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Here is a patch that changes the superuser check in lp to use
capabilities instead.

Does anyone see a problem with it before I send it to Linus?

Tim.
*/

2001-01-05 Tim Waugh <twaugh@redhat.com>

        * drivers/char/lp.c: Capability check instead of superuser check.
        Patch from acme@connectiva.com.br.

--- linux-2.4.0/drivers/char/lp.c.lp Wed Nov 1 15:06:20 2000
+++ linux-2.4.0/drivers/char/lp.c Fri Jan 5 10:58:18 2001
@@ -485,7 +485,7 @@
                         if (copy_to_user((int *) arg, &LP_STAT(minor),
                                         sizeof(struct lp_stats)))
                                 return -EFAULT;
- if (suser())
+ if (capable(CAP_SYS_ADMIN))
                                 memset(&LP_STAT(minor), 0,
                                                 sizeof(struct lp_stats));
                         break;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Marek Gresko: "2.4.0 TCP SYN problem"
• Previous message: Horst von Brand: "2.4.0-ac1 on sparc64: Build problems"
• Next in thread: David Weinehall: "suser() check audit Was: [patch] 2.4.0: lp superuser check"
• Reply: David Weinehall: "suser() check audit Was: [patch] 2.4.0: lp superuser check"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jan 07 2001 - 21:00:22 EST