Re: [PATCH] drop-behind fix for generic_file_write

From: Daniel Phillips (phillips@innominate.de)
Date: Wed Jan 03 2001 - 10:21:17 EST

Next message: Michael Rothwell: "Re: Journaling: Surviving or allowing unclean shutdown?"
Previous message: Rik van Riel: "Re: Journaling: Surviving or allowing unclean shutdown?"
In reply to: Rik van Riel: "[PATCH] drop-behind fix for generic_file_write"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 03 Jan 2001, Rik van Riel wrote:
> Hi Linus, Alan,
>
> the following (trivial) patch fixes drop-behind behaviour
> in generic_file_write to only drop fully written pages.
>
> This increases performance in dbench by about 8% (as
> measured by Daniel Phillips) and should get rid of the
> logfile bottleneck Ingo Molnar found with the drop-behind
> call in generic_file_write in TUX tests.

Rik, I detected the speedup in -pre5 but it disappeared in -pre7 (which
turned in a faster performance than pre5 or 6 anyway). I don't have an
explanation for that. The idea makes sense: treat a partial page as
'in play' until completely full, then deactivate it.

-- 
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Michael Rothwell: "Re: Journaling: Surviving or allowing unclean shutdown?"
Previous message: Rik van Riel: "Re: Journaling: Surviving or allowing unclean shutdown?"
In reply to: Rik van Riel: "[PATCH] drop-behind fix for generic_file_write"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jan 07 2001 - 21:00:15 EST