Re: [PATCH][RFC] Converting drivers/net/rcpci45.c to new PCI API

From: Rasmus Andersen (rasmus@jaquet.dk)
Date: Tue Dec 19 2000 - 04:10:41 EST


> > + unregister_netdev(dev);
> > + iounmap((void *)dev->base_addr);
> > + free_irq(dev->irq, dev);
>
> I'd rather inhibit irq first then release the ressources.
> + free_irq(dev->irq, dev);
> + iounmap((void *)dev->base_addr);
> + unregister_netdev(dev);

Fair enough. I just copied the sequence used in the original but your
suggestion makes sense. I'll do that in my next patch.

Thanks for the eyeballs :),
  Rasmus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Dec 23 2000 - 21:00:24 EST