Re: [patch] 2.2.18 PCI_DEVICE_ID_OXSEMI_16PCI954

From: Tim Waugh (twaugh@redhat.com)
Date: Sat Dec 16 2000 - 18:21:13 EST


On Fri, Dec 15, 2000 at 09:57:42PM +0100, Lukasz Trabinski wrote:

> In serial dirver from Theodore Ts'o we have:
>
> { PCI_VENDOR_ID_SPECIALIX, PCI_DEVICE_ID_OXSEMI_16PCI954,

This is for a serial port device.

> (IMHO that is correct), but in kernel 2.2.18 we have:
> (include/kernel/pci.h)
> #define PCI_DEVICE_ID_OXSEMI_16PCI954PP 0x9513
> ^^

This is for a parallel port device. They are two logically different
things, have two distinct PCI bus entries, and so have two distinct
PCI device IDs and consequently different names.

> -#define PCI_DEVICE_ID_OXSEMI_16PCI954PP 0x9513
> +#define PCI_DEVICE_ID_OXSEMI_16PCI954 0x9513

Alan, do not apply, this will break the parport code.

If the OXSEMI_16PCI954 is _missing_, it probably ought to be _added_,
but it does not have 0x9513 as its ID and so the existing name should
not be changed.

Tim.
*/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Dec 23 2000 - 21:00:17 EST