On Fri, 15 Dec 2000, Andrea Arcangeli wrote:
> On Fri, Dec 15, 2000 at 11:29:28AM -0500, Mike Black wrote:
> > include/linux/signal.h
> >
> > There's a couple like this -- isn't this case statement upside down???
> >
> > extern inline void siginitset(sigset_t *set, unsigned long mask)
> > {
> > set->sig[0] = mask;
> > switch (_NSIG_WORDS) {
> > default:
> > memset(&set->sig[1], 0, sizeof(long)*(_NSIG_WORDS-1));
> > break;
> > case 2: set->sig[1] = 0;
> > case 1:
> > }
> > }
> >
> > gcc is complaining:
> > /usr/src/linux/include/linux/signal.h:193: warning: deprecated use of label
> > at end of compound statement
>
> You're using a too recent gcc (I got flooded too indeed). I disagree with such
> a warning, current code makes perfect sense.
>
> Andrea
Current code makes perfect sense if you put a 'break;' after the last
label. This doesn't generate any code, but makes the source comply with
the new rule.
Cheers,
Dick Johnson
Penguin : Linux version 2.4.0 on an i686 machine (799.54 BogoMips).
"Memory is like gasoline. You use it up when you are running. Of
course you get it all back when you reboot..."; Actual explanation
obtained from the Micro$oft help desk.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Dec 15 2000 - 21:00:32 EST