Re: INIT_LIST_HEAD marco audit

From: Mohammad A. Haque (mhaque@haque.net)
Date: Sun Dec 10 2000 - 23:14:54 EST


Does this look right to people?

--- linux-2.4.0-test12.old/drivers/pcmcia/tcic.c Sun Nov 19 21:56:30
2000
+++ linux-2.4.0-test12/drivers/pcmcia/tcic.c Sun Dec 10 23:00:07 2000
@@ -548,8 +548,9 @@
         }
 }
 
-static struct tq_struct tcic_task = {
- routine: tcic_bh
+DECLARE_TASK_QUEUE(tcic_task);
+struct tq_struct run_tcic_task = {
+ routine: (void (*)(void *)) tcic_bh
 };
 
 static void tcic_interrupt(int irq, void *dev, struct pt_regs *regs)
--- linux-2.4.0-test12.old/drivers/pcmcia/i82365.c Sun Nov 19 21:56:30
2000
+++ linux-2.4.0-test12/drivers/pcmcia/i82365.c Sun Dec 10 23:06:01 2000
@@ -877,8 +877,9 @@
         }
 }
 
-static struct tq_struct pcic_task = {
- routine: pcic_bh
+DECLARE_TASK_QUEUE(pcic_task);
+struct tq_struct run_pcic_task = {
+ routine: (void (*)(void *)) pcic_bh
 };
 
 static void pcic_interrupt(int irq, void *dev,

Miles Lane wrote:
> Would someone who knows what to do send out a patch for
> these two drivers?
>
> drivers/pcmcia/i82365.c
> drivers/pcmcia/tcic.c

-- 

===================================================================== Mohammad A. Haque http://www.haque.net/ mhaque@haque.net

"Alcohol and calculus don't mix. Project Lead Don't drink and derive." --Unknown http://wm.themes.org/ batmanppc@themes.org ===================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Dec 15 2000 - 21:00:21 EST