Re: [PATCH] Re: fs corruption with invalidate_buffers()

From: Alexander Viro (viro@math.psu.edu)
Date: Thu Dec 07 2000 - 17:26:46 EST


On Thu, 7 Dec 2000, Udo A. Steinberg wrote:

> Jan Niehusmann wrote:
> >
> > The following patch actually prevents the corruption I described.
> >
> > I'd like to hear from the people having problems with hdparm, if it helps
> > them, too.
>
> Yes, it prevents the issue.
>
> > Please note that the patch circumvents the problem more than it fixes it.
> > The true fix would invalidate the mappings, but I don't know how to do it.
>
> I don't know either. What does Alexander Viro say to all of this?

That invalidate_buffers() should leave the unhashed ones alone. If it can't
be found via getblk() - just leave it as is.

IOW, let it skip bh if (bh->b_next == NULL && !destroy_dirty_buffers).
No warnings needed - it's a normal situation.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Dec 07 2000 - 21:00:18 EST