RE: test12-pre6

From: Dunlap, Randy (randy.dunlap@intel.com)
Date: Wed Dec 06 2000 - 20:30:23 EST


> From: Linus Torvalds [mailto:torvalds@transmeta.com]
>
...
> Now, this is with a bog-standard PIIX irq router, so we
> definitely know
> that we have the pirq table parsing right. I even have unofficial
> confirmation from intel engineers on this.
>
> But I see something obviously wrong there: you have busmaster
> disabled.
>
> Looking into the UHCI controller code, I notice that neither
> UHCI driver actually does the (required)
>
> pci_set_master(dev);
>
> Please add that to just after a successful
> "pci_enable_device(dev)", and I
> just bet your USB will start working.
>
> Johannes, Georg, the above is a fairly embarrassing bug, and
> is likely to
> explain a _lot_ of USB failures (the OHCI driver does do this, btw).
>
> Linus

Gawd, I'm embarrassed even if they aren't.
You probably just wiped out a significant portion of the
USB bug list.

Thanks,
~Randy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Dec 07 2000 - 21:00:16 EST