On Wed, 6 Dec 2000, Tigran Aivazian wrote:
> (correction to my previous message -- the immutable thing to return
EPERM
~~~~~
I meant EACCES. And I think Linux does the right thing but FreeBSD is
broken. The rationale is in the definition of EACCES and EPERM, taken from
SuSv2 (and why would you let it "be damned" if you just relied on it
yourself in your own patch? Though you used an old/obsolete version called
POSIX).
Let's look at the definitions:
[EACCES]
Permission denied An attempt was made to access a file in a way
forbidden by its file access permissions.
[EPERM]
Operation not permitted An attempt was made to perform an
operation limited to processes with appropriate privileges or to
the owner of a file or other resource.
Now, in the case of truncating immutable files we are trying to violate
file access permissions _and_ there is no special privilege that we could
possess which would allow us to succeed in this case. So EPERM is not
right but EACCES is right. So, the current state of Linux is correct but
inefficient and the patch below is an optimization (+ Al Viro's fixes).
Regards,
Tigran
> is not just a good idea, it is imperative and Linux already does that --
> so we can drop that check from if() unconditionally, which is what the
> patch below does).
>
> Tested under 2.4.0-test12-pre6.
>
> Regards,
> Tigran
>
> --- linux/fs/open.c Thu Oct 26 16:11:21 2000
> +++ work/fs/open.c Wed Dec 6 08:05:43 2000
> @@ -102,7 +102,12 @@
> goto out;
> inode = nd.dentry->d_inode;
>
> - error = -EACCES;
> + /* For directories it's -EISDIR, for other non-regulars - -EINVAL */
> + error = -EISDIR;
> + if (S_ISDIR(inode->i_mode))
> + goto dput_and_out;
> +
> + error = -EINVAL;
> if (!S_ISREG(inode->i_mode))
> goto dput_and_out;
>
> @@ -110,12 +115,8 @@
> if (error)
> goto dput_and_out;
>
> - error = -EROFS;
> - if (IS_RDONLY(inode))
> - goto dput_and_out;
> -
> error = -EPERM;
> - if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
> + if (IS_APPEND(inode))
> goto dput_and_out;
>
> /*
> @@ -163,7 +164,7 @@
> goto out;
> dentry = file->f_dentry;
> inode = dentry->d_inode;
> - error = -EACCES;
> + error = -EINVAL;
> if (!S_ISREG(inode->i_mode) || !(file->f_mode & FMODE_WRITE))
> goto out_putf;
> error = -EPERM;
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Dec 07 2000 - 21:00:15 EST