On Mon, 4 Dec 2000, Tigran Aivazian wrote:
> It is true that your patch fixes the problem as reported but let us look
> one step deeper into the problem. Linux supports multiply mounted
> instances of a filesystem and the check in sys_link() comparing the
> mountpoints would refuse (with cross-device link error) linking between
> them. This is correct. However, one level down, inside vfs_link() we also
> check for ->i_dev match and that seems unnecessary, now that (with your
> patch) link(2) would work correctly anyway.
>
> Therefore, I propose a slightly modified (tested under
> 2.4.0-test12-pre4) version of the patch. What do you think? My philosophy
> is -- since you made this feature work properly you should make it work
> efficiently too and that means removing redundant code.
Tigran, think about the uses from knfsd.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Dec 07 2000 - 21:00:11 EST