Re: [PATCH] inode dirty blocks Re: test12-pre4

From: Alexander Viro (viro@math.psu.edu)
Date: Mon Dec 04 2000 - 14:54:49 EST


On Mon, 4 Dec 2000, Stephen C. Tweedie wrote:

> Agreed. However, is there any reason to have this as a separate
> function? bforget() should _always_ remove the buffer from any inode
> queue. You can make that operation conditional on (bh->b_inode !=
> NULL) if you want to avoid taking the lru lock unnecessarily.

I doubt it. bforget() is called, for example, when we deal with the
changed branch in ext2_get_block() (the thing had been partially read,
but then we've noticed that it had been changed under us). And I don't
think that brelse() would be a good thing there...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Dec 07 2000 - 21:00:11 EST