Re: bug in count_open_files() or a strange granularity?

From: Tigran Aivazian (tigran@veritas.com)
Date: Tue Nov 28 2000 - 10:40:39 EST


On Tue, 28 Nov 2000, David S. Miller wrote:
> What you want is something like:
>
> static int num_open_files(struct files_struct *files, int size)
> {
> total = 0;
> for (i = size / (8 * sizeof(long)); i > 0; )
> total += count_bits(files->open_fds->fds_bits[--i]);
>
> return total;
> }

Ok, since we have to walk the sets and test the bits anyway, I propose to
make close_files() to return 'nr_open_fds' and accept an extra argument
'doclose=0 or 1' which will specify whether we want to close the 'fd' or
whether we just want to count them.

Regards,
Tigran

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 30 2000 - 21:00:19 EST