Re: [PATCH] removal of "static foo = 0"

From: Herbert Xu (herbert@gondor.apana.org.au)
Date: Sat Nov 25 2000 - 18:33:10 EST


On Sat, Nov 25, 2000 at 11:46:24PM +0100, Andries Brouwer wrote:
>
> But if the program
>
> static int a = 0;
>
> int main() {
> /* do something */
> }
>
> is used as part of a larger program, it has to become
>
> static int a;
>
> int do_something() {
> a = 0;
> ...
> }

Only if the person doing the change follows this convention, if that happens
to be you, not a problem. But in a project like Linux, it's not very likely
to happen.

It's much better to put a comment above the definition.

-- 
Debian GNU/Linux 2.2 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 30 2000 - 21:00:14 EST