Re: *_trylock return on success?

From: Rik van Riel (riel@conectiva.com.br)
Date: Sat Nov 25 2000 - 12:49:25 EST


On Sat, 25 Nov 2000, Roger Larsson wrote:

> Questions:
> What are _trylocks supposed to return?

It depends on the type of _trylock ;(

> Does spin_trylock and down_trylock behave differently?
> Why isn't the expected return value documented?

The whole trylock stuff is, IMHO, a big mess. When you
change from one type of trylock to another, you may be
forced to invert the logic of your code since the return
code from the different locks is different.

For bitflags, for example, the trylock returns the state
the bit had before the lock (ie. 1 if the thing was already
locked).

For spinlocks, it'll probably return something else ;/

regards,

Rik

--
Hollywood goes for world dumbination,
	Trailer at 11.

http://www.conectiva.com/ http://www.surriel.com/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 30 2000 - 21:00:14 EST