Re: 2.2.18pre, usb mouse messages

From: Peter Samuelson (peter@cadcamlab.org)
Date: Fri Nov 24 2000 - 01:31:11 EST


> > usb-uhci.c: interrupt, status 3, frame# 212
> > hub.c: already running port 2 disabled by hub (EMI?), re-enabling...

[Greg KH]
> The messages are harmless debug messages. Anyone want to whip up a
> patch to turn them off (like was recently done for 2.4.0-test)?

Is this what you mean?

Peter

diff -urk.bak 2.2.18-19/drivers/usb/hub.c.bak 2.2.18-19/drivers/usb/hub.c
--- 2.2.18-19/drivers/usb/hub.c.bak Fri Nov 3 19:20:45 2000
+++ 2.2.18-19/drivers/usb/hub.c Fri Nov 24 00:29:50 2000
@@ -530,11 +530,8 @@
                                 // be shutdown by the hub, this hack enables them again.
                                 // Works at least with mouse driver.
                                 if (!(portstatus & USB_PORT_STAT_ENABLE) &&
- (portstatus & USB_PORT_STAT_CONNECTION) && (dev->children[i])) {
- err("already running port %i disabled by hub (EMI?), re-enabling...",
- i + 1);
+ (portstatus & USB_PORT_STAT_CONNECTION) && (dev->children[i]))
                                         usb_hub_port_connect_change(dev, i);
- }
                         }
 
                         if (portstatus & USB_PORT_STAT_SUSPEND) {
diff -urk.bak 2.2.18-19/drivers/usb/usb-uhci.c.bak 2.2.18-19/drivers/usb/usb-uhci.c
--- 2.2.18-19/drivers/usb/usb-uhci.c.bak Fri Nov 3 19:20:46 2000
+++ 2.2.18-19/drivers/usb/usb-uhci.c Fri Nov 24 00:21:16 2000
@@ -2538,16 +2538,10 @@
 
         dbg("interrupt");
 
- if (status != 1) {
- warn("interrupt, status %x, frame# %i", status,
- UHCI_GET_CURRENT_FRAME(s));
+ // remove host controller halted state
+ if ((status&0x20) && (s->running))
+ outw (USBCMD_RS | inw(io_addr + USBCMD), io_addr + USBCMD);
 
- // remove host controller halted state
- if ((status&0x20) && (s->running)) {
- outw (USBCMD_RS | inw(io_addr + USBCMD), io_addr + USBCMD);
- }
- //uhci_show_status (s);
- }
         /*
          * traverse the list in *reverse* direction, because new entries
          * may be added at the end.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 30 2000 - 21:00:11 EST