Re: Locking question, is this cool?

• Next message: Andrea Arcangeli: "Re: [PATCH] 2.4.0-test10-pre6 TLB flush race in establish_pte"
• Previous message: George Anzinger: "Locking question, is this cool?"
• In reply to: George Anzinger: "Locking question, is this cool?"
• Next in thread: George Anzinger: "Re: Locking question, is this cool?"
• Reply: George Anzinger: "Re: Locking question, is this cool?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> At line 1073 of ../drivers/char/i2lib.c (2.4.0-test9) we find:
>
> WRITE_LOCK_IRQSAVE(...
>
> this is followed by:
>
> COPY_FROM_USER(...
>
> It seems to me that this could result in a page fault with interrupts
> off. Is this ok?

It wont do what you want - it'll re-enable irqs and may then deadlock. It might
need to copy the buffer to a temporary space then take the lock >
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Andrea Arcangeli: "Re: [PATCH] 2.4.0-test10-pre6 TLB flush race in establish_pte"
• Previous message: George Anzinger: "Locking question, is this cool?"
• In reply to: George Anzinger: "Locking question, is this cool?"
• Next in thread: George Anzinger: "Re: Locking question, is this cool?"
• Reply: George Anzinger: "Re: Locking question, is this cool?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Oct 31 2000 - 21:00:30 EST