Re: [PATCH] make my life easier ...

From: Tom Rini (trini@kernel.crashing.org)
Date: Wed Oct 25 2000 - 12:59:00 EST


On Wed, Oct 25, 2000 at 01:42:52PM +0200, Martin Mares wrote:
> Hello!
>
> > "The Linux 'original' IDE guy' Mark Lord showed Alan what was trying to
> > bang over everyone's head, without success.
> >
> > Here is his sample code for cs5530 chipset.
> >
> > Look at this and comment. I have part of the space setup to complete the
> > APM extenstion calls. This will get you and me out of a jam with laptops.
>
> This doesn't make much sense to me: Why don't we just reinitialize the timings
> as we do when programming the chipset instead of saving/restoring the state?

Aside from all of the other comments that've been made, because the user might
have tweeked them at boot. ie turn on UDMA. If we just re-initalized on
wakeup, you loose this.

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 31 2000 - 21:00:16 EST