Re: Patch for /proc/mounts problems on 2.2.x

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Wed Oct 25 2000 - 04:20:57 EST


Christian Czezatke wrote:
> Unfortunately, I had to discover that /proc/mounts does not show all the
> mounting options (usrquota, grpquota).

These options are ignored. linux/fs/ext2/super.c from 2.2.18-pre17:

        /* Silently ignore the quota options */
        else if (!strcmp (this_char, "grpquota")
                 || !strcmp (this_char, "noquota")
                 || !strcmp (this_char, "quota")
                 || !strcmp (this_char, "usrquota"))
                /* Don't do anything ;-) */ ;
        else {
                printk ("EXT2-fs: Unrecognized mount option %s\n",
this_char);
                return 0;
        }

> -- Furthermore, the max. size of
> /proc/mounts is limited to one page. Even worse, the current
> implementation in Linux 2.2.17 and 2.2.18preX does not perform proper
> bounds checking. (I've successfully triggered off an OOPS by exploiting
> this on a box running Linux 2.2.17).

Don't mount so many filesystems, or don't use so many no-op options :)

-- 
Jeff Garzik                    | The difference between laziness and
Building 1024                  | prioritization is the end result.
MandrakeSoft                   |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 31 2000 - 21:00:15 EST