Re: new 3dfx framebuffer driver released

From: David S. Miller (
Date: Tue Oct 10 2000 - 19:03:44 EST

   From: Kesmarki Attila <>
   Date: Wed, 11 Oct 2000 02:02:24 +0200

   A made my latest release as a patch for 2.4.0-test9. It can be
   downloaded from I won't attach
   it, because it's too long.

One bug spotted, in tdfxfb_probe():

+ info->bufbase_virt =
+ ioremap_nocache(info->bufbase_phys, info->bufbase_size);
+ if (!info->regbase_virt) {
+ printk("fb: Can't remap %s framebuffer.\n", name);
+ iounmap(info->regbase_virt);
+ goto err3;
+ }

Looks like a cut&paste error, you need to check info->bufbase_virt
against NULL, not info->regbase_virt ;-)

David S. Miller
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Sun Oct 15 2000 - 21:00:16 EST