Re: sbpcd bug in 2.4.0...

From: Jens Axboe (axboe@suse.de)
Date: Thu Sep 21 2000 - 09:30:11 EST

Next message: Albert D. Cahalan: "Re: [RFC] Wine speedup through kernel module"
Previous message: Jan Niehusmann: "Re: lvm in 2.4.0-test9pre5"
In reply to: ismael ripoll: "sbpcd bug in 2.4.0..."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Sep 21 2000, ismael ripoll wrote:
> The problem seems to be originatied by the new block devices
> interface..

Right

> The bug Is that in the function sbpcd_end_request
> the value of "req->q" is NULL.. and then:
>
> list_add(&req->queue, &req->q->queue_head); << FAILS >>

And I don't see why it should do this. It would make more sense
to just leave the current request in the queue, and let end_request
deal with dequeueing when it is done.

Could you try this patch? Completely untested and note even compiled :)

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs

text/plain attachment: sbpcd_queue.diff

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/

Next message: Albert D. Cahalan: "Re: [RFC] Wine speedup through kernel module"
Previous message: Jan Niehusmann: "Re: lvm in 2.4.0-test9pre5"
In reply to: ismael ripoll: "sbpcd bug in 2.4.0..."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 21:00:24 EST