dev->hard_start_xmit return val handling correct?

• Next message: Craig Whitmore: "Intel D815EEA Motherboard (ethernet driver)"
• Previous message: Horst von Brand: "Re: [PATCH] abuse of macros in swab.h"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

When dev->hard_start_xmit returns an error, it doesn't seem like
returning ENETDOWN is the best course of action.. Is this correct?

int dev_queue_xmit(struct sk_buff *skb)
[...]
               if (dev->hard_start_xmit(skb, dev) == 0) {
                       dev->xmit_lock_owner = -1;
                       spin_unlock_bh(&dev->xmit_lock);
                       return 0;
               }
       }
       dev->xmit_lock_owner = -1;
       spin_unlock_bh(&dev->xmit_lock);
       if (net_ratelimit())
               printk(KERN_DEBUG "Virtual device %s asks to queue
packet!\n", dev->name);
       kfree_skb(skb);
       return -ENETDOWN;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Craig Whitmore: "Intel D815EEA Motherboard (ethernet driver)"
• Previous message: Horst von Brand: "Re: [PATCH] abuse of macros in swab.h"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 21:00:24 EST