Re: [PATCH] Re: SCSI scanning

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Sep 18 2000 - 21:47:53 EST


On Mon, 18 Sep 2000, David S. Miller wrote:
>
> The problem is that regardless of the tpnt->present setting, the
> MOD_DEC_USE_COUNT must occur.
>
> And again, why did this not show up with modules?
>
> I have no idea, I'm just the messenger in this case :-)

Hey, I didn't shoot you, I just want somebody from the SCSI camp to say
something.

Can you test whether changing the

        if (tpnt->present)
                return;

to a

        if (tpnt->present) {

                .. indent the linked list code and the remove_proc_entry stuff ..
        }

fixes the oops for you?

> The boot logs looked something like (note the request_module messages,
> wheee...):

That "request_module[]: Root fs not mounted" message is going to get a lot
more common (and actually get removed) - there's a lot of stuff where we
want to exec a user mode helper, but where the bootup case is special. So
igore that - it's going away, by virtue of making the printk() disappear
;)

> SCSI device sdb: hdwr sector= 512 bytes. Sectors= 4194995 [2048 MB] [2.0 GB]
> sdb: sdb1 sdb2 sdb3
> ...
> scsi : 2 hosts.
>
> And precisely here is where the OOPS was seen.

Yeah, it's just after the ESP case, getting ready to do the ncr case..
Which will be silent due to not having any controller - until it oopses on
you.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 21:00:19 EST