On Sun, 17 Sep 2000, Linus Torvalds wrote:
>
> This is the patch I was looking for. Thanks,
Oh, grepping some more for scsi initializations, the "scsi_dev_init()"
thing stands out.
That's another case where the SCSI layer is module dependent. If it's a
module, we use the "init_module()" in scsi/scsi.c, and if not, we instead
use "scsi_dev_init()". They do some of the same things (well, they
obviously would have to, otherwise there wouldn't be any point to having a
init routine at all), but in general do it in very different ways for no
good reason I can see.
Torben, would you mind terribly expanding on your previous patch a bit,
and also cleaning this part up? As far as I can tell, we should just
remove scsi_dev_init() completely, and use the module init code with an
initcall(). Two less regions of #ifdef MODULE, and one less different
code-path to worry about..
Why was this done this way anyway? I've never seen this kind of setup in
any of the other drivers that have been de-liced of module dependencies..
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 21:00:15 EST