Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups

From: Philipp Rumpf (
Date: Wed Aug 30 2000 - 14:02:06 EST

On Wed, Aug 30, 2000 at 10:04:12AM -0700, Linus Torvalds wrote:
> return copy_to_user(dst, src, size) ? -EFAULT : 0;
> is fine and quite readable. Fits on a simple line.

I agree so far. But when it's really

        if (put_user(..>)
                return -EFAULT;
        if (put_user(...))
                return -EFAULT;
        if (copy_to_user(...))
                return -EFAULT;
        if (copy_to_user(...))
                return -EFAULT;

        return 0;

changing the last two statements to use ? : is just confusing (acme's changes
were somewhat less extreme), don't you agree ?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:26 EST