Re: [PATCH] Fix disk statistic reporting to include all disks

From: Jens Axboe (
Date: Tue Aug 29 2000 - 18:15:36 EST

On Tue, Aug 29 2000, Linus Torvalds wrote:
> > This patch fixes the enhanced disk statistics to report all drives
> > so IDE1 - IDE3 (/dev/hdc - /dev/hdh) can be monitored.
> Why not just do this right, and move the statistics into the "queue
> structure". Get rid of that ugly kstat thing. Get rid of all the special
> case lookups. We already need to have the queue structure to do the
> queuing (surprise, surprise), so suddenly statistics are (a) cheap and (b)
> right.
> So then /proc just needs to be changed to look at the queues instead of
> looking at this kstat thing.

Sounds sane, but what about drivers that don't really use the request
queue structure? Stuff like lvm, md, rd (with Neil's patch to fix the
lru_list deadlock), and probably new loop.

Come to think of it, regular disk stat accounting doesn't work there atm

* Jens Axboe <>
* SuSE Labs
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:24 EST