Re: [PATCH] serial167.c: take 2: bugfixes and cleanups

From: Rogier Wolff (R.E.Wolff@BitWizard.nl)
Date: Sat Aug 26 2000 - 04:14:59 EST

Next message: Arjan van de Ven: "Re: 2.4.0 test 7 won't compile for me"
Previous message: Tigran Aivazian: "Re: linux kernel v2.4.0-test7 problems"
In reply to: Tigran Aivazian: "Re: [PATCH] serial167.c: take 2: bugfixes and cleanups"
Next in thread: Richard Hirst: "Re: [PATCH] serial167.c: take 2: bugfixes and cleanups"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Tigran Aivazian wrote:
> On Sat, 26 Aug 2000, Rogier Wolff wrote:
> > I always try to write the code that calls the "support functions"
> > first. As a programmer I'm lazy: I get to write clean code, knowing
> > that the support functions will handle the details. In the end it pays
> > off.
> >
>
> have a look at fs/super.c:copy_mount_options(), please. It does make use
> of the return values from copy_from_user().

Ok. So: we need to retain the old version, and have a new version that
is easy-to-use, in a different situation.

Roger.

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
*       Common sense is the collection of                                *
******  prejudices acquired by age eighteen.   -- Albert Einstein ********
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Arjan van de Ven: "Re: 2.4.0 test 7 won't compile for me"
Previous message: Tigran Aivazian: "Re: linux kernel v2.4.0-test7 problems"
In reply to: Tigran Aivazian: "Re: [PATCH] serial167.c: take 2: bugfixes and cleanups"
Next in thread: Richard Hirst: "Re: [PATCH] serial167.c: take 2: bugfixes and cleanups"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:17 EST