Re: [PATCH] cleanup on selection.c

From: Jes Sorensen (
Date: Fri Aug 25 2000 - 13:38:56 EST

>>>>> "Matthew" == Matthew Wilcox <> writes:

Matthew> On Fri, Aug 25, 2000 at 10:05:19AM -0300, Arnaldo Carvalho de
Matthew> Melo wrote:
>> /* does screen address p correspond to character at LH/RH edge of
>> screen? */

Matthew> this is wrong.

Matthew> return copy_from_user_ret(inwordLut, (u32 *)(arg+4),
Matthew> 32, -EFAULT);

Returning from inside a macro is really foul - it is very hard read
and debug.

Please change the code to

        if (copy_from_user(foo, bar, boo))
                return -EFAULT;
        return 0;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:16 EST