flags_t

From: Cesar Eduardo Barros (cesarb@nitnet.com.br)
Date: Wed Aug 23 2000 - 13:54:54 EST

Next message: Paavo Nikula: "test7-pre7 compile error [reiserfs]"
Previous message: Jonathan Brauer: "__generic_copy_from_user question"
Next in thread: Jes Sorensen: "Re: flags_t"
Maybe reply: Jes Sorensen: "Re: flags_t"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

I have always been annoyed by the fact that save/restore_flags save/restore the
flags using an unsigned long variable. I think it would be clearer to use

typedef struct { unsigned long _flags; } flags_t;

or something like that.

Also, I've seen people confused by the "pass by reference" conventions of both
functions. It might be remotely useful to change it to a true function-like
style passing a pointer to the variable instead.

-- 
Cesar Eduardo Barros
cesarb@nitnet.com.br
cesarb@dcc.ufrj.br
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Paavo Nikula: "test7-pre7 compile error [reiserfs]"
Previous message: Jonathan Brauer: "__generic_copy_from_user question"
Next in thread: Jes Sorensen: "Re: flags_t"
Maybe reply: Jes Sorensen: "Re: flags_t"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Aug 23 2000 - 21:00:09 EST