Re: [PATCH] Re: Move of input drivers, some word needed from you

From: Linus Torvalds (torvalds@transmeta.com)
Date: Tue Aug 22 2000 - 11:23:39 EST


On Tue, 22 Aug 2000, Bjorn Wesen wrote:
>
> SOmething similar to the skb's would be preferable - so I can just take
> write blocks and chain them into the DMA hardware. Incoming data can go
> into "skb's" as well up to the tty.

No. That is just horrible. What's so wrong with simple flip-buffers that
they wouldn't work for you? Simple, and you can fill them up as fast as
you can and then flip. Sure, if nobody reads the buffers fast enough
you'll have trouble, but that's independent of how you do things. It's a
basic law of the universe (called the "if nobody is listening, it doesn't
matter how loudly or slowly you talk" law).

If you don't like the circular queues, you can just get rid of those.
Although I don't see what the difference between a circular queue and two
buffers you flip between really is. The circular queues work well for many
things, and are there because that's how the original tty layer worked..

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Aug 23 2000 - 21:00:07 EST