Re: dev_mc_lock question.

From: Gleb Natapov (gleb@nbase.co.il)
Date: Tue Aug 22 2000 - 01:16:28 EST

Next message: Greg KH: "Re: When to submit something? and: signed executables."
Previous message: Kari Lempiainen: "Re: Trouble with MultiTech serial card"
Next in thread: kuznet@ms2.inr.ac.ru: "Re: dev_mc_lock question."
Reply: kuznet@ms2.inr.ac.ru: "Re: dev_mc_lock question."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

kuznet@ms2.inr.ac.ru wrote:
>
> Hello!
>
> > Can somebody explain me please why 'dev_mc_lock' is global for all
> > network devices and not one per 'net_device' structure?
>
> Do you modify mc lists each other microsecond? 8)8)

No, but I want to call 'dev_mc_add()', 'dev_mc_delete()' from
'dev->set_multicast_list()' (where 'dev' is virtual device) and this
cause deadlock on smp because of global 'dev_mc_lock'.

>
> In any case, this lock is bug as whole. mc lists should be modified
> only under dev->xmit_lock.

So, is it safe to remove it? Do you want me to send patch?

PS: you accidentally CCed the answer to the old list (vger.rutgers.edu)
:)

--
			Gleb.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Greg KH: "Re: When to submit something? and: signed executables."
Previous message: Kari Lempiainen: "Re: Trouble with MultiTech serial card"
Next in thread: kuznet@ms2.inr.ac.ru: "Re: dev_mc_lock question."
Reply: kuznet@ms2.inr.ac.ru: "Re: dev_mc_lock question."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Aug 23 2000 - 21:00:06 EST