Re: [PATCH] Re: Move of input drivers, some word needed from you

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Aug 21 2000 - 17:31:22 EST


On Mon, 21 Aug 2000, Philipp Rumpf wrote:
>
> > If hierarchy leads to having to look more places, think about it more, and
>
> According to my proposal, we would end up having all network drivers in
> drivers/*/net/*.

But even that isn't enough, as shown by the tulip driver: basically even
the regular PC drivers are available in so many different setups that
you'd still want sub-hierarchies.

(drivers/pc/ would end up being about 99% of the drivers, with the rest
being just smatterings here and there).

> I would say drivers/s390/net and drivers/s390/misc are good directories.

I would not disagree entirely. At the same time, there would be advantages
to arch/s390/drivers too. Especially if most people aren't that interested
in them - keep them out of the way.

Keeping them out of the way is bad at times (ie those times when changes
are made that affect everybody). But at other times it would be exactly
what you want. Not polluting the namespace with stuff you don't want or
need is nice.

What I'm saying is that it's not a case of "this is the right solution".

I think drivers/input _is_ a good solution. I think it sucks as a solution
if it implies moving all the drivers that need it into the same place, but
I think it's potentially the right answer if it's localized to the "core
input handling routines" and people see it that way (kind of the same way
drivers/pci works - not all pci drivers are there, but it is a good way to
partition the _generic_ issues about PCI somewhere which is neutral wrt
what the driver actually ends up doing).

But other issues, like how to move things around.. I'm not going to make
that choice as long as it's not the "obviously right one". As long as it's
not clear what the best choice is, the best bet is always "do as little as
possible, and nothing more".

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Aug 23 2000 - 21:00:05 EST