[PATCH] drivers/char/pcwd.c: kmalloc fixes

• Next message: Michael Rothwell: "Re: NTFS-like streams?"
• Previous message: Arnaldo Carvalho de Melo: "[PATCH] drivers/char/pc_keyb.c: checking resource allocation"
• Next in thread: Bill Wendling: "Re: [PATCH] drivers/char/pcwd.c: kmalloc fixes"
• Reply: Bill Wendling: "Re: [PATCH] drivers/char/pcwd.c: kmalloc fixes"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

      Please take a look and consider applying.

                        - Arnaldo

--- linux-2.4.0-test7-pre3/drivers/char/pcwd.c Thu Jul 13 01:58:42 2000
+++ linux-2.4.0-test7-pre3.acme/drivers/char/pcwd.c Mon Aug 14 13:55:30 2000
@@ -40,6 +40,8 @@
  * fairly useless proc entry.
  * 990610 removed said useless proc code for the merge <alan>
  * 000403 Removed last traces of proc code. <davej>
+ * 000814 Change kmalloc by a static char array, kmalloc can fail
+ * Arnaldo Carvalho de Melo <acme@conectiva.com.br>
  */
 
 #include <linux/module.h>
@@ -503,9 +505,7 @@
 static inline char *get_firmware(void)
 {
         int i, found = 0, count = 0, one, ten, hund, minor;
- char *ret;
-
- ret = kmalloc(6, GFP_KERNEL);
+ static char ret[6];
 
         while((count < 3) && (!found)) {
                 outb_p(0x80, current_readport + 2);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Michael Rothwell: "Re: NTFS-like streams?"
• Previous message: Arnaldo Carvalho de Melo: "[PATCH] drivers/char/pc_keyb.c: checking resource allocation"
• Next in thread: Bill Wendling: "Re: [PATCH] drivers/char/pcwd.c: kmalloc fixes"
• Reply: Bill Wendling: "Re: [PATCH] drivers/char/pcwd.c: kmalloc fixes"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:33 EST