Re: ioremap return type

From: Jes Sorensen (jes@linuxcare.com)
Date: Thu Aug 10 2000 - 10:40:06 EST


>>>>> "Jamie" == Jamie Lokier <lk@tantalophile.demon.co.uk> writes:

Jamie> Many drivers use a struct to define the offsets in their I/O or
Jamie> iomem space. E.g. acenic.c: readl(&regs->CpuCtrl). We know
Jamie> that's not portable in the sense that struct layout is not
Jamie> guaranteed. However, provided all the fields are suitably
Jamie> padded & aligned, it works in practice. (So far..)

That is perfectly portable because that maps onto the hardware
registers directly, the driver is not to known whether an IO spase is
sparse or not thats handle by readl/writel. The acenic driver simply
uses the struct to generate offsets because I find it utterly ugly to
use a zillion defines to set all the offsets.

Jes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:21 EST