Re: [PATCH] partial fix for Thinkpads and suspend

From: Garst R. Reese (reese@isn.net)
Date: Wed Aug 09 2000 - 03:25:14 EST


Stephen Rothwell wrote:
>
> Hi Garst,
>
> "Garst R. Reese" <reese@isn.net> writes:
> >
> > Hmm, how does changing APM_DO_CLI fix the fact that in test5-pre2, an
> > explicit cli() was issued? (in the function suspend at line 914).
> > I do not understand how you avoid that cli.
>
> I don't :-)
> BUT after the cli() call, suspend() calls apm_set_power_state()
> which calls set_power_state() which calls apm_bios_call_simple()
> which (after my patch) will do __sti() (in APM_DO_CLI) for you
> (if you have CONFIG_APM_ALLOW_INTS set) ...
>
> Please try the patch ...
>
> Cheers,
> Stephen
OK, so it works on my old 380XD also :) test6-pre9
Thanks for the explaination. I guess I'll let Linus apply it.;)
Garst

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:17 EST