Re: recent names_cachep change

From: Linus Torvalds (torvalds@transmeta.com)
Date: Thu Jul 27 2000 - 15:31:03 EST


On Thu, 27 Jul 2000, Tigran Aivazian wrote:
>
> diff -urN -X dontdiff linux/init/main.c work/init/main.c
> --- linux/init/main.c Thu Jul 27 07:31:21 2000
> +++ work/init/main.c Thu Jul 27 21:04:35 2000
> @@ -565,6 +565,7 @@
> fork_init(mempages);
> filescache_init();
> dcache_init(mempages);
> + namecache_init();

At least move it into dcache init, and consider the name cache to be a
higher-level thing. I dislike the way init/main.c is always expanded, and
I want to _stop_ everybody always addign stuff to init/main.c. It ends up
both ugly and a patch nightmare.

For example, I like how people can add filesystems without having to touch
_any_ generic files any more. Ther used to be all these things with
fs/filesystems.c etc that had to be in sync.

I don't think init/main.c should need to care how the VFS layer does its
name cache initialization. All of this should probably be moved into
"vfs_init()", and none of this random collection of random init routines
in one long list...

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 31 2000 - 21:00:24 EST