[PATCH] removal of unnecessary irq save/restore in tasklet_hi_schedule

From: Daniel Marmier (daniel.marmier@lightning.ch)
Date: Tue Jul 25 2000 - 22:11:40 EST

Hi Linus,

If my understanding is correct :
a) tasklet_hi_schedule is to be called by hardirqs
b) hardirqs cannot be re-entered

So tasklet_hi_schedule does not need to save/restore flags. The
following patchlet should make it simpler.

Have a nice day,

                                Daniel Marmier

--- linux-2.4.0-test4/include/linux/interrupt.h Tue Jul 25 08:49:58 2000
+++ linux-2.4.0-test4-dm1/include/linux/interrupt.h Wed Jul 26 03:46:21 2000
@@ -183,13 +183,10 @@
 {
         if (!test_and_set_bit(TASKLET_STATE_SCHED, &t->state)) {
                 int cpu = smp_processor_id();
- unsigned long flags;
 
- local_irq_save(flags);
                 t->next = tasklet_hi_vec[cpu].list;
                 tasklet_hi_vec[cpu].list = t;
                 __cpu_raise_softirq(cpu, HI_SOFTIRQ);
- local_irq_restore(flags);
         }
 }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Jul 31 2000 - 21:00:20 EST