Re: uPatch for mm/filemap.c

• Next message: Pablo Baena: "Re: [MAYBE NOT SO] Bug on lp.o? on kernel-2.2.15"
• Previous message: Martin Costabel: "Re: devfs question"
• In reply to: Roberto Fichera: "uPatch for mm/filemap.c"
• Next in thread: Dave Jones: "Re: uPatch for mm/filemap.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Jul 15 2000, Roberto Fichera wrote:
> Hi All,
>
> I've notice a double page_cache_release() in
> mm/filemap.c:truncate_inode_pages(). Here is the patch
>
> --- linux-2.4.0-test4/mm/filemap.c.orig Sat Jul 15 16:33:17 2000
> +++ linux-2.4.0-test4/mm/filemap.c Sat Jul 15 16:33:47 2000
> @@ -199,7 +199,6 @@
>
> UnlockPage(page);
> page_cache_release(page);
> - page_cache_release(page);
>
> /*
> * We have done things without the pagecache lock,

This will give you serious problems, I doubt you have even tried running
for more than a couple of minutes with this? We are freeing the page
and a couple of lines further up we page_cache_get() the page -- alas,
two releases.

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Pablo Baena: "Re: [MAYBE NOT SO] Bug on lp.o? on kernel-2.2.15"
• Previous message: Martin Costabel: "Re: devfs question"
• In reply to: Roberto Fichera: "uPatch for mm/filemap.c"
• Next in thread: Dave Jones: "Re: uPatch for mm/filemap.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Jul 15 2000 - 21:00:22 EST