[PATCH] Watch out for those flags!

From: Anton Blanchard (anton@linuxcare.com)
Date: Fri Jul 14 2000 - 18:04:29 EST


Hi,

A recent change was made to the scheduler which broke sparc32 SMP. You dont
know what you might catch passing flags around like that.

Anton

Index: kernel/sched.c
===================================================================
RCS file: /cvs/linux/kernel/sched.c,v
retrieving revision 1.165
diff -u -r1.165 sched.c
--- kernel/sched.c 2000/07/14 00:36:16 1.165
+++ kernel/sched.c 2000/07/14 23:07:22
@@ -209,8 +209,11 @@
  * We enter with the runqueue spinlock held, but we might end
  * up unlocking it early, so the caller must not unlock the
  * runqueue, it's always done by reschedule_idle().
+ *
+ * This function must be inline as anything that saves and restores
+ * flags has to do so within the same register window on sparc (Anton)
  */
-static void reschedule_idle(struct task_struct * p, unsigned long flags)
+static inline void reschedule_idle(struct task_struct * p, unsigned long flags)
 {
 #ifdef CONFIG_SMP
         int this_cpu = smp_processor_id();

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jul 15 2000 - 21:00:21 EST