Re: Proposal: non-PC ISA bus support

From: Geert Uytterhoeven (geert@linux-m68k.org)
Date: Tue Jun 20 2000 - 12:29:14 EST

On Tue, 20 Jun 2000, Frank Rowand wrote:
> Geert Uytterhoeven wrote:
> > The following patch fixes 2 problems related to ISA bus access on non-PC
> > platforms:

    [...]

> Would it make sense to apply the same sort of fix to the following code in
> __ioremap(), so that ISA space is handled consistently?:
>
> /*
> * If the address lies within the first 16 MB, assume it's in ISA
> * memory space
> */
> if (p < 16*1024*1024)
> p += _ISA_MEM_BASE;

Yes. I added that correction because the NVRAM driver wants to ioremap() the
NVRAM region as reported by the OF device tree, while on CHRP boxes with PC
style NVRAM, it's in ISA memory space at 0xe0000 (`nvram@me0000', according to
OF).

Gr{oetje,eeting}s,

                                                Geert 

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Fri Jun 23 2000 - 21:00:20 EST