Another ramfs bug (?)

• Next message: bug1: "Re: kernel panic: raid1 + loop"
• Previous message: shiv agarwal: "Porting from X86 to RISC Processor."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

ramfs_prepare_write()) used to look like this:

static int ramfs_prepare_write(struct file *file, struct page *page,
unsigned offset, unsigned to)
{
        void *addr;

        addr = (void *) kmap(page);
        if (!Page_Uptodate(page)) {
                memset(addr, 0, PAGE_CACHE_SIZE);
                SetPageUptodate(page);
        }
        SetPageDirty(page);
        return 0;
}

In test1-ac20, the:
               addr = (void *) kmap(page);
line was removed.

Surely this can't be right - addr is now used uninitialised in the
memset().

-- 
David Gibson, Technical Support Engineer, Linuxcare, Inc.
+61 2 6262 8990
dgibson@linuxcare.com, http://www.linuxcare.com/ 
Linuxcare. Support for the revolution.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: bug1: "Re: kernel panic: raid1 + loop"
• Previous message: shiv agarwal: "Porting from X86 to RISC Processor."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Jun 23 2000 - 21:00:18 EST