Re: [PATCH] ramfs fixes

From: Rik van Riel (riel@conectiva.com.br)
Date: Mon Jun 19 2000 - 09:02:22 EST


On Mon, 19 Jun 2000, David Gibson wrote:

> The PG_dirty bit is cleared in add_to_swap_cache() and
> __add_to_page_cache() so this is kind of redundant, but the
> detach_page hook is good news in general.

Oww, good that you alert me to this bug. It makes no sense to
clear the bit there since we may have dirty pages in both the
filecache and the swapcache...

(well, it doesn't cause any bugs, but it could add some nasty
surprises later when we change the code so we can have dirty
pages in all the caches)

regards,

Rik

--
The Internet is not a network of computers. It is a network
of people. That is its real strength.

Wanna talk about the kernel? irc.openprojects.net / #kernelnewbies http://www.conectiva.com/ http://www.surriel.com/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jun 23 2000 - 21:00:16 EST