On Sat Jun 17, 2000 at 04:51:10PM +0100, Alan Cox wrote:
> Ok I'm going for stabilising the oddments 2.2.16 got a bit wrong before
> we move onwards. This even though a pre patch should be somewhat more
> solid than 2.2.16. It contains just the important bug fixes
As we discussed last week or so, struct sysinfo can overflow unsigned longs
under 2.2.x (you mentioned mounting multple 2GiB swap files as an example).
Is this something worth fixing in 2.2.x?
A nice fix would be to include the new 2.4.x sysinfo struct into 2.2.x, set
sysinfo.mem_unit=1 (to retain binary compatability), and then ensure that
sysinfo.totalram and friends never overflow (by checking places that can change
the totalram values such as linux/mm/swapfile.c and linux/arch/*/mm/init.c).
Would you accept such a fix if I code it up? This would obviate the need for a
sysinfo64 for old and new kernel binary compatability...
-- Erik B. Andersen Web: http://www.xmission.com/~andersen/ email: firstname.lastname@example.org --This message was written using 73% post-consumer electrons--
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to email@example.com Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Jun 23 2000 - 21:00:15 EST