[patch available] Oops when mounting floppy

From: Andries Brouwer (aeb@veritas.com)
Date: Wed May 24 2000 - 07:29:25 EST

Hmm - with 2.3.99 more oopses in a week than around 0.99 in a year.
Many different people change the code, and nobody knows the rules.

I just got an oops mounting a floppy, and looking at what
went wrong it became clear that the author of the floppy driver
assumed the rule: check_media_change() can be called only after
open() has been called. Before the recent changes that was true:
We did blkfops->open(), and then read_super() which called
Today check_disk_change() is called in get_sb_bdev() before
blkdev_get() does the open.

So various fixes are possible: move the check_disk_change()
call, or fix the floppy driver. Unfortunately the floppy
driver is a pile of kludges, so fixing it either means
adding one more kludge - this is the four-line solution -
or rewriting a lot of stuff.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed May 31 2000 - 21:00:11 EST