Re: [PATCH] int (*readpage)(struct file *, struct page *);

From: Jamie Lokier (
Date: Thu May 11 2000 - 07:44:58 EST

Roman V. Shaposhnick wrote:
> * all address space operations get a "struct file *" pointer[1]. It will
> contain a hint from kernel when it is available and NULL if it is not.

Linus already noted that it needs to be clear this can be NULL --
perhaps to the extent of having two separate functions, one with and one
without the file pointer.

May I humbly suggest you name the argument `struct file * file_or_null',
so that filesystem implementors don't make the mistake of assuming it
is always set?

-- Jamie

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:17 EST