get_sb_single/bdev/nodev asymmetry - a bug?

From: Tigran Aivazian (tigran@veritas.com)
Date: Wed May 10 2000 - 02:35:49 EST


Hi Alexander,

I noticed that mount_sem is down'd and up'd in bdev/nodev versions of
get_sb_XXX() but only down'd in get_sb_single(). I also see that the
caller (do_sys_mount) does up(&mount_sem) but never downs it. I thought
up() without a down() is illegal..

Shouldn't get_sb_single() up it or should the other two *not* up it and
let do_sys_mount do it? (i.e. whether the rest of the code in
do_sys_mount() has to be protected by mount_sem or not).

Regards,
Tigran

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:15 EST