Re: PATCH: Bug in invalidate_inode_pages()?

From: Juan J. Quintela (
Date: Mon May 08 2000 - 18:55:52 EST

>>>>> "linus" == Linus Torvalds <> writes:


linus> On 9 May 2000, Juan J. Quintela wrote:
>> I think that I have found a bug in invalidate_inode_pages.
>> It results that we don't remove the pages from the
>> &inode->i_mapping->pages list, then when we return te do the next loop
>> through all the pages, we can try to free a page that we have freed in
>> the previous pass.

linus> This is what "remove_inode_page()" does. Maybe that's not quite clear
linus> enough, so this function may certainly need some comments or something
linus> like that, but your patch is wrong (it will now delete the thing twice,
linus> which can and will result in list corruption).

Then there is the same inode->i_mapping_>pages list and page->list?
If that is the case I think that I would make one comment there
indicating that.

Later, Juan.

In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to Please read the FAQ at

This archive was generated by hypermail 2b29 : Mon May 15 2000 - 21:00:12 EST