Re: Updates to /bin/bash

From: Andrea Arcangeli (andrea@suse.de)
Date: Sat May 06 2000 - 08:15:44 EST


On Fri, 5 May 2000, Trond Myklebust wrote:

>NO. This behaviour is exactly what Andreas patch would break. New

My patch won't hurt the bash update as far I can tell.

In clean 2.2.15 and clean 2.3.99-pre7-pre6 you don't unmap the page from
the ptes, so if nfs doesn't keep to do the pageins from the inode pointed
by the nfsfilehandle, then you'll get a mixture anyway even if you drop
the mapped pages from the cache (and nfs probably can't keep do to the
pageins from the old file if somebody replaced bash on the real fs but in
the worst case nfs should notice that and it should abort the `bash`
execution and to never do the silent mixture).

New executed bash are not an issue since they will get a new inode present
on the server and so they won't risk to do the mixture.

All above thoughts assumes the admin correctly uses remove(2) to upgrade
bash (otherwise the mixture would happen also on top of ext2).

About the stability issue I looked some more and maybe the VM is not
subject to stability issues by dropping a mapped cache-page from the cache
(however the thing keeps to look not robust to me). Everything depends on
the page->index that have to be not clobbered after dropping the page from
the cache (while page->index is supposed to have a meaning only on
pagecache or swapcache).

Andrea

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:19 EST