Re: [patch] Yenta module race condition

From: Linus Torvalds (torvalds@transmeta.com)
Date: Fri May 05 2000 - 00:58:20 EST


In article <20000504235323.A800@informatics.muni.cz>,
Jan Kasprzak <kas@informatics.muni.cz> wrote:
>: - link yenta.o and pci_socket.o into _one_ object file (somewhat like the
>: other pcmcia object files are packaged together)
>
> OK, the second try - patch attached. I have named the resulting module
>"pci_sockets.o" - feel free to suggest a better name.
>
> But I think this is still not a clean solution of the problem:
>Suppose they are other cardbus bridge drivers than yenta.o -- they all
>have to be linked to one object with pci_socket.o. Not very modular, IMHO.

Hmm?

They can still share all the source code. Which is the important
thing, after all.

Also, it's not using any more memory - show me a machine that has both a
CardBus controller and a PCI-only legacy PCMCIA controller, and I'll
show you a machine that is probably used for PCMCIA testing and little
more ;)

pci_socket.c is meant to be modular, but it really only makes sense to
modularize on a source level - there is no real gain in trying to share
it on a binary level with other drivers.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:16 EST